This repository was archived by the owner on Sep 24, 2020. It is now read-only.
Replacing "keypress" event binding to "keyup" as "keypress" is #78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deprecated and doesn't work on all browsers, like the Android default browser.
|
Looks like keyup has some side-effects that I didn't notice. Investigating further. |
|
Give angular-credit-cards 2.3 a shot. I've added formatting that does a reasonably good job of getting the cursor position right without breaking out of Angular's native input handling events. It's quite consistent and simple for now which I think is best until I can really devote the time to aggressive cross-browser testing of a vanilla JS approach. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacing "keypress" event binding to "keyup" as "keypress" isn't covered by any official specification and doesn't work on all browsers, like the Android default browser as observed in #71